From 063514c48b266a22eca80e1db0591f5f8b41ecac Mon Sep 17 00:00:00 2001 From: Jonathan Amsterdam Date: Wed, 3 Jul 2019 13:06:27 -0400 Subject: [PATCH] internal/lsp/cmd: replace time.Tick with time.After time.Tick produces multiple ticks (and leaks a Ticker); time.After produces a single tick, which is what is called for here. Change-Id: I922b11e1263a8367afec76c10831b7284f3559ec Reviewed-on: https://go-review.googlesource.com/c/tools/+/184938 Reviewed-by: Rebecca Stambler Reviewed-by: Ian Cottrell Run-TryBot: Rebecca Stambler TryBot-Result: Gobot Gobot --- internal/lsp/cmd/check.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/internal/lsp/cmd/check.go b/internal/lsp/cmd/check.go index c5d9960b..0aa07faf 100644 --- a/internal/lsp/cmd/check.go +++ b/internal/lsp/cmd/check.go @@ -59,7 +59,7 @@ func (c *check) Run(ctx context.Context, args ...string) error { for _, file := range checking { select { case <-file.hasDiagnostics: - case <-time.Tick(30 * time.Second): + case <-time.After(30 * time.Second): return fmt.Errorf("timed out waiting for results from %v", file.uri) } file.diagnosticsMu.Lock()