Muir Manders eda2c2f1ae internal/lsp: fix completion insertion with non-identifier suffix ... Completions like "foo.Bar(baz.<>)" were replacing one too many characters resulting in "foo.Bar(baz.Qux()". This is because the go parser adds a phantom "_" identifier when parsing "foo.". We thought the "_" was really there, so we were issuing text edits to replace it. Fix by ignoring "_" selectors when the cursor is positioned to their left. Fixes microsoft/vscode-go#2525 Change-Id: I1233a9d6275e2a79b666ca0230862238160b4aab GitHub-Last-Rev: de9a3f00187b1b9bfcc4e497461f4602ae6f8923 GitHub-Pull-Request: golang/tools#104 Reviewed-on: https://go-review.googlesource.com/c/tools/+/178217 Reviewed-by: Rebecca Stambler <rstambler@golang.org> Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>		2019-05-20 21:53:15 +00:00
..
apidiff	apidiff: represent a Report as a list of Changes	2019-04-22 23:39:26 +00:00
fastwalk	internal/fastwalk: avoid slice bounds out of range for long file names	2018-11-12 23:16:31 +00:00
gopathwalk	imports: stop using go/packages for modules	2019-01-22 20:29:12 +00:00
imports	imports: rename to internal/imports	2019-05-20 21:49:35 +00:00
jsonrpc2	internal/jsonrpc2: fix bug in direction logging of call responses	2019-04-06 16:55:26 +00:00
lsp	internal/lsp: fix completion insertion with non-identifier suffix	2019-05-20 21:53:15 +00:00
module	imports: stop using go/packages for modules	2019-01-22 20:29:12 +00:00
semver	go/packages: add name= query	2018-10-16 20:20:09 +00:00
span	internal/span: update the offset if the end offset should be valid but is not	2019-05-03 18:46:43 +00:00
tool	internal/tool: add a small package to unify the flag handling across all our tools	2018-12-17 23:08:00 +00:00
txtar	imports: stop using go/packages for modules	2019-01-22 20:29:12 +00:00