e5f3ab76ea
The first issue is that %b and %o can print pointers, but printVerbs didn't reflect that: The %b, %d, %o, %x and %X verbs also work with pointers, formatting the value exactly as if it were an integer. The second issue is that arrays can never be printed as pointers. This was previously reported as part of #27672. The third issue is that only %p can print all slices, maps, and functions as if they were pointers. This differs from verbs like %b or %o, which can't print these types as pointers. Fix all of the issues above, and add extensive test cases covering all the combinations. Verified all of them with an executed program. The amount of test cases is perhaps overkill, but this is not the first time we've gotten the printf pointer logic wrong. Updates #27672. Fixes #28858. Change-Id: I62eb79d505fd1e250a16b90bda3c68b702f35a29 Reviewed-on: https://go-review.googlesource.com/c/149979 Run-TryBot: Daniel Martí <mvdan@mvdan.cc> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Alan Donovan <adonovan@google.com> |
||
|---|---|---|
| .. | ||
| asmdecl | ||
| assign | ||
| atomic | ||
| bools | ||
| buildssa | ||
| buildtag | ||
| cgocall | ||
| composite | ||
| copylock | ||
| ctrlflow | ||
| findcall | ||
| httpresponse | ||
| inspect | ||
| internal/analysisutil | ||
| loopclosure | ||
| lostcancel | ||
| nilfunc | ||
| nilness | ||
| pkgfact | ||
| printf | ||
| shadow | ||
| shift | ||
| stdmethods | ||
| structtag | ||
| tests | ||
| unmarshal | ||
| unreachable | ||
| unsafeptr | ||
| unusedresult | ||
| README | ||
README
This directory does not contain a Go package, but acts as a container for various analyses that implement the golang.org/x/tools/go/analysis API and may be imported into an analysis tool. By convention, each package foo provides the analysis, and each command foo/cmd/foo provides a standalone driver.