close_issue_1
/
tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
tools/internal/lsp/protocol
History
Ian Cottrell a8f40b3f4d internal/jsonrpc2: split main loop from construction to fix race 
This changes the basic API of a jsonrpc2 connection to run the
read loop as a method rather than in a go routine launched in
the NewConn. This allows the handler to be created and bound
between construction and the read loop starting, which fixes
the race.

Fixes golang/go#30091

Change-Id: I8201175affe431819cf473e5194d70c019f58425
Reviewed-on: https://go-review.googlesource.com/c/tools/+/170003
Run-TryBot: Ian Cottrell <iancottrell@google.com>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
 		2019-03-29 19:31:51 +00:00
..
preserve tools/cmd/gopls: modify gopls to use automatcally generated types 2019-03-12 15:13:52 +00:00
typescript tools/internal/lsp/protocol: generate LSP protocol types from source 2019-03-12 15:15:45 +00:00
client.go internal/jsonrpc2: change to a more synchronous dispatch model 2018-11-14 19:09:51 +00:00
doc.go internal/lsp: the core lsp protocol 2018-09-25 15:17:08 +00:00
printers.go internal/lsp: convert to the new location library 2019-03-13 19:34:21 +00:00
protocol.go internal/jsonrpc2: split main loop from construction to fix race 2019-03-29 19:31:51 +00:00
server.go tools/cmd/gopls: modify gopls to use automatcally generated types 2019-03-12 15:13:52 +00:00
span.go internal/span: change to private fields 2019-03-15 18:05:47 +00:00
tsprotocol.go tools/cmd/gopls: modify gopls to use automatcally generated types 2019-03-12 15:13:52 +00:00