close_issue_1
/
tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
tools/internal/lsp/source
History
Muir Manders 7d7faa4812 internal/lsp: fix missing parens in function call snippet 
We were omitting the parens in function completions like "(foo<>)()"
because our check thought "foo" was the Fun in the outer CallExpr so
it already had parens. Fix by tightening up logic to only omit parens
for cases like "foo<>()" and "foo.bar<>()".

Change-Id: Ia602b80275f72baa6cdf6d61c22d3f3a6cfc3019
GitHub-Last-Rev: 41fecf92617e0812ee6552d8c43789eae83889bd
GitHub-Pull-Request: golang/tools#98
Reviewed-on: https://go-review.googlesource.com/c/tools/+/176944
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
 		2019-05-15 01:24:06 +00:00
..
analysis.go internal/lsp: add more error propagation and logging for analyses 2019-04-24 02:44:48 +00:00
completion.go internal/lsp: stop trimming prefix from InsertText 2019-05-13 23:30:21 +00:00
completion_format.go internal/lsp: add additional error handling for builtin packages 2019-05-10 13:52:03 +00:00
completion_snippet.go internal/lsp: fix missing parens in function call snippet 2019-05-15 01:24:06 +00:00
diagnostics.go internal/lsp: fix nil pointer when propagating diagnostics 2019-05-14 14:35:49 +00:00
enums.go internal/lsp: switch completion item tests to using the enum strings 2019-04-17 17:57:43 +00:00
format.go internal/lsp: normalise and make public diff<->edit conversions 2019-04-15 20:31:36 +00:00
highlight.go internal/lsp: add support for document highlight 2019-03-26 19:08:20 +00:00
hover.go internal/lsp: fix typo on license year 2019-05-14 17:17:24 +00:00
identifier.go internal/lsp: add definition support for packages 2019-05-10 15:10:30 +00:00
signature_help.go internal/lsp: add definition support for packages 2019-05-10 15:10:30 +00:00
source_test.go internal/lsp: ignore files in the builtin package 2019-05-14 23:09:02 +00:00
symbols.go internal/lsp: make interface methods children of the interface symbol 2019-04-24 02:46:01 +00:00
util.go internal/lsp: add some missing copyright notices 2019-05-11 04:16:17 +00:00
view.go internal/lsp: add definition support for packages 2019-05-10 15:10:30 +00:00