Go to file
Alan Donovan 63c6481f3b go/loader: fix a data race
The loader was calling (*types.Checker).Files on the "unsafe" package,
a global variable.  Even with zero files, this operation is not a no-op
because it sets the package's "complete" flag, leading to a data race.
(Because Unsafe.complete is already set at construction, the
race is benign, but is reported by -race nonetheless.)

Fixes golang/go#20718

Change-Id: I5a4f95be5ab4c60ea3b6c2a7fb6f1b67acbf42bc
Reviewed-on: https://go-review.googlesource.com/46071
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
2017-06-19 17:45:44 +00:00
benchmark/parse benchmark/parse: fix cosmetic defect in error str. 2015-02-02 17:07:43 +00:00
blog blog/atom: support atom:link as in RFC4287 4.2.7 2017-02-04 21:42:09 +00:00
cmd cmd/go-contrib-init: fix in-GOPATH check 2017-06-14 16:55:02 +00:00
container/intsets Revert "x/tools/container/intsets: remove unused function" 2017-03-01 14:51:44 +00:00
cover cover: fixed broken error message 2016-03-08 18:20:19 +00:00
go go/loader: fix a data race 2017-06-19 17:45:44 +00:00
godoc godoc: add links to docs in text and dir pages 2017-06-16 21:49:54 +00:00
imports imports: prefer paths imported by sibling files. 2017-06-09 17:18:19 +00:00
playground playground/socket: deflake test, remove sleep 2016-12-11 02:33:14 +00:00
present x/tools/present: fix element number check 2017-06-08 00:01:16 +00:00
refactor refactor/rename: add line number to ambiguityError 2017-05-10 14:27:37 +00:00
third_party cmd/heapview: dowgrade to customelements v0 2016-08-05 20:49:36 +00:00
.gitattributes tools: copying .gitattributes to all subrepositories (fixes windows build) 2014-12-23 06:32:51 +00:00
.gitignore dashboard: rearrange tree, in prep for packagification 2015-01-15 02:58:11 +00:00
AUTHORS go.empty: prototype for new subrepository 2012-01-25 14:45:13 -05:00
CONTRIBUTING.md doc: add CONTRIBUTING.md 2015-02-18 23:43:38 +00:00
CONTRIBUTORS go.empty: prototype for new subrepository 2012-01-25 14:45:13 -05:00
LICENSE LICENSE: add 2012-03-17 15:20:58 +11:00
PATENTS go.empty: add PATENTS file to the subrepo. 2012-04-16 11:24:04 +10:00
README x/tools: s/oracle/guru/g in various comments 2016-10-13 18:54:04 +00:00
codereview.cfg tools: add codereview.cfg 2015-03-18 17:04:00 +00:00

README

This subrepository holds the source for various packages and tools that support
the Go programming language.

Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with "go get".

Packages include a type-checker for Go and an implementation of the
Static Single Assignment form (SSA) representation for Go programs.

To submit changes to this repository, see http://golang.org/doc/contribute.html.