The loader was calling (*types.Checker).Files on the "unsafe" package, a global variable. Even with zero files, this operation is not a no-op because it sets the package's "complete" flag, leading to a data race. (Because Unsafe.complete is already set at construction, the race is benign, but is reported by -race nonetheless.) Fixes golang/go#20718 Change-Id: I5a4f95be5ab4c60ea3b6c2a7fb6f1b67acbf42bc Reviewed-on: https://go-review.googlesource.com/46071 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> |
||
|---|---|---|
| benchmark/parse | ||
| blog | ||
| cmd | ||
| container/intsets | ||
| cover | ||
| go | ||
| godoc | ||
| imports | ||
| playground | ||
| present | ||
| refactor | ||
| third_party | ||
| .gitattributes | ||
| .gitignore | ||
| AUTHORS | ||
| CONTRIBUTING.md | ||
| CONTRIBUTORS | ||
| LICENSE | ||
| PATENTS | ||
| README | ||
| codereview.cfg | ||
README
This subrepository holds the source for various packages and tools that support the Go programming language. Some of the tools, godoc and vet for example, are included in binary Go distributions. Others, including the Go guru and the test coverage tool, can be fetched with "go get". Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs. To submit changes to this repository, see http://golang.org/doc/contribute.html.