close_issue_1
/
tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
tools/internal/lsp/cache
History
Muir Manders 47ea21585c internal/lsp: propagate context.Canceled when type checking 
typeCheck() was swallowing context.Canceled errors and leaving the
cached package in a bad state. In particular, after two rapid changes
to imports I was left in the "no package for file" error mode until I
change my imports again. The second change canceled the first change
which ended up sticking a skeleton *pkg in the package cache instead
of propagating the canceled error.

Change-Id: I15b072188c3359d9cd1812bd49e72548ba214250
GitHub-Last-Rev: 240f61718fbb5bfc787bbfaaaae1d38925d7c405
GitHub-Pull-Request: golang/tools#126
Reviewed-on: https://go-review.googlesource.com/c/tools/+/183940
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
 		2019-06-26 23:41:52 +00:00
..
cache.go internal/lsp: separate refactorings out of memoization CL 2019-06-25 16:04:30 +00:00
check.go internal/lsp: propagate context.Canceled when type checking 2019-06-26 23:41:52 +00:00
external.go internal/lsp: fix panic in computing file version 2019-06-26 19:26:56 +00:00
file.go internal/lsp: separate refactorings out of memoization CL 2019-06-25 16:04:30 +00:00
gofile.go internal/lsp: support a file belonging to multiple packages 2019-06-26 17:56:19 +00:00
load.go internal/lsp: support a file belonging to multiple packages 2019-06-26 17:56:19 +00:00
modfile.go internal/lsp: separate refactorings out of memoization CL 2019-06-25 16:04:30 +00:00
parse.go internal/lsp: support a file belonging to multiple packages 2019-06-26 17:56:19 +00:00
pkg.go internal/lsp: plumb suggested fixes through the LSP 2019-06-26 21:02:18 +00:00
session.go internal/lsp: support a file belonging to multiple packages 2019-06-26 17:56:19 +00:00
sumfile.go internal/lsp: separate refactorings out of memoization CL 2019-06-25 16:04:30 +00:00
token.go internal/lsp: separate refactorings out of memoization CL 2019-06-25 16:04:30 +00:00
view.go internal/lsp: support a file belonging to multiple packages 2019-06-26 17:56:19 +00:00
watcher.go internal/lsp: add file watching and use it to trigger invalidations 2019-05-24 14:03:12 +00:00