close_issue_1
/
tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
tools/internal/lsp
History
Muir Manders 3e93b52866 internal/lsp: suppress more completions in comments and literals 
Completion suppression in comments wasn't working for comments in
switch case statements, select case statements, and decl statements.
Rather than adding those to the list of leaf ast.Node types to look
for, we now always check if the position is in a comment. This fix
broke some completion tests that were using re"$" since "$" matches
after the comment "//" characters.

We now also don't complete within any literal values. Previously we
only excluded string literals.

Change-Id: If02f39f79fe2cd7417e39dbac2c6f84a484391ec
GitHub-Last-Rev: 7ab3f526b6752a8f74413dcd268382d359e1beba
GitHub-Pull-Request: golang/tools#88
Reviewed-on: https://go-review.googlesource.com/c/tools/+/173518
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
 		2019-04-24 20:52:08 +00:00
..
cache internal/lsp: use ast.Nodes for hover information 2019-04-18 23:52:43 +00:00
cmd internal/lsp: fix error handling in cmd 2019-04-22 18:06:12 +00:00
diff internal/lsp: normalise and make public diff<->edit conversions 2019-04-15 20:31:36 +00:00
protocol internal/lsp: fix typo on 'textDocument/foldingRange' method 2019-04-22 18:44:13 +00:00
source internal/lsp: suppress more completions in comments and literals 2019-04-24 20:52:08 +00:00
testdata internal/lsp: suppress more completions in comments and literals 2019-04-24 20:52:08 +00:00
tests internal/lsp: suppress more completions in comments and literals 2019-04-24 20:52:08 +00:00
xlog internal/lsp: add the ability to log back to the client 2019-04-01 16:22:08 +00:00
code_action.go internal/lsp: run source.organizeImports on all codeActions 2019-04-16 21:54:00 +00:00
completion.go internal/lsp: add type to placeholders in completion parameters 2019-04-19 19:58:23 +00:00
definition.go internal/lsp: refactor server.go to separate into LSP categories 2019-04-17 20:54:51 +00:00
diagnostics.go internal/lsp: add more error propagation and logging for analyses 2019-04-24 02:44:48 +00:00
format.go internal/lsp: refactor server.go to separate into LSP categories 2019-04-17 20:54:51 +00:00
general.go internal/lsp: use ast.Nodes for hover information 2019-04-18 23:52:43 +00:00
highlight.go internal/lsp: refactor server.go to separate into LSP categories 2019-04-17 20:54:51 +00:00
hover.go internal/lsp: support comments on hover for typenames, funcs, fields 2019-04-22 16:38:38 +00:00
lsp_test.go internal/lsp: improve composite literal completion 2019-04-23 22:28:03 +00:00
server.go internal/lsp: fix typo on 'textDocument/foldingRange' method 2019-04-22 18:44:13 +00:00
signature_help.go internal/lsp: refactor server.go to separate into LSP categories 2019-04-17 20:54:51 +00:00
symbols.go internal/lsp: refactor server.go to separate into LSP categories 2019-04-17 20:54:51 +00:00
text_synchronization.go internal/lsp: add additional debug logging for diagnostics 2019-04-22 21:11:31 +00:00
util.go internal/lsp: refactor server.go to separate into LSP categories 2019-04-17 20:54:51 +00:00