The typechecker's Sizes function is not currently set correctly. The correct answer requires information known only to the build system's query tool (go list, blaze query, etc), and we need to add a mechanism for it to return this information. In the meantime, we use this simple workaround: if the GOARCH environment variable is set, we use that to determine sizes according to the conventions of gc. Otherwise, we use the architecture for which the application was compiled. Both could easily be incorrect, but this is nonetheless progress. This change should fix the tests of go/analysis/passes/shift, which are currently broken for GOARCH=386 because the analysistest driver uses go/packages, which ignores GOARCH. Change-Id: Iabe3211ad513a9a94eadd6d8f4b2068f7abdd053 Reviewed-on: https://go-review.googlesource.com/c/141757 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> |
||
---|---|---|
.. | ||
analysis | ||
ast | ||
buildutil | ||
callgraph | ||
cfg | ||
gccgoexportdata | ||
gcexportdata | ||
internal | ||
loader | ||
packages | ||
pointer | ||
ssa | ||
types | ||
vcs |