close_issue_1
/
tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
tools/go/packages
History
Michael Matloob 1aadbdfdbb go/packages: make sure TypesSizes are requested when Types are 
This code fixes a bug when a user specifies NeedTypes, which
implicitly requires TypesSizes, but TypesSizes isn't fetched,
which causes typechecking to explode.

Also fix a similar issue where NeedImports isn't implicitly
fetched for NeedDeps.

I added a TODO for a better fix, which is to have an "implicitMode"
in the loader type containing all the data that's needed as a prerequisite
for other fields. Then we can use implicitMode when fetching data,
and cfg.Mode to clear out the fields the user didn't request.

Fixes golang/go#31163

Change-Id: If3506765470af43dfb24d06fcbd31b66a623f2e0
Reviewed-on: https://go-review.googlesource.com/c/tools/+/170342
Reviewed-by: Ian Cottrell <iancottrell@google.com>
 		2019-04-03 18:03:48 +00:00
..
gopackages go/package/gopackages: update gopackages to use the new tool library for its main function 2019-01-08 19:17:02 +00:00
packagestest internal/lsp: add support for document highlight 2019-03-26 19:08:20 +00:00
testdata go/packages/testdata: add go directives to fake module files 2019-03-22 20:32:07 +00:00
doc.go go/packages: rename name= query and "disable" it 2019-01-29 21:16:23 +00:00
example_test.go go/packages: remove the Config.Error hook 2018-09-04 20:52:37 +00:00
external.go go/packages: fix json struct tag on driverRequest.Command 2019-04-02 20:06:28 +00:00
golist.go go/packages: make sure TypesSizes are requested when Types are 2019-04-03 18:03:48 +00:00
golist_overlay.go go/packages: check for containing files after overlay is processed 2018-12-06 19:48:17 +00:00
packages.go go/packages: make sure TypesSizes are requested when Types are 2019-04-03 18:03:48 +00:00
packages110_test.go go/packages: generate test main files from the golist fallback 2018-09-17 22:19:12 +00:00
packages_test.go go/packages: make sure TypesSizes are requested when Types are 2019-04-03 18:03:48 +00:00
packagescgo_test.go go/...: use recommended issue tracker URLs 2018-12-05 01:41:16 +00:00
stdlib_test.go go/...: use recommended issue tracker URLs 2018-12-05 01:41:16 +00:00
visit.go go/packages: make visit order stable 2018-11-02 02:37:01 +00:00