asmdecl:
- MOVW $x+0(FP) is OK if x is big, because $x is an address
(happens in internal/cpu, golang.org/x/sys/cpu, runtime)
- ignore TEXT lines in comments
(happens in runtime/internal/atomic)
- wasm's CallImport instruction writes return results
(happens in syscall)
- allow write out-of-bounds (SP) references in NOFRAME functions
(happens in runtime)
- recognize "NOP SP" as an SP "write" to disable SP bounds checking
- 'go test' in passes/asmdecl was not testing all architectures; fix that
stdmethods:
- ignore WriteTo if obviously not io.WriterTo (as in go/types and runtime/pprof)
errorsas:
- don't complain about package errors testing invalid calls
structtag:
- don't complain about encoding/json and encoding/xml testing invalid tags
unmarshal:
- don't complain about encoding/gob, encoding/json, encoding/xml testing invalid calls
For golang/go#31916.
Fixesgolang/go#25822.
Change-Id: I322c08b5991ffc4995112b8ea945161a4c5193ce
Reviewed-on: https://go-review.googlesource.com/c/tools/+/176097
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Michael Matloob <matloob@golang.org>
...and other trivial cleanups.
Multi-line doc comments have been moved to exported Doc constants for
the sake of godoc.
Change-Id: Ib1cbec5806c699d51283c34685c4cd96953f5384
Reviewed-on: https://go-review.googlesource.com/c/142360
Reviewed-by: Michael Matloob <matloob@golang.org>
Also: extend analysistest to extract '// want ...' comments
out of non-Go source files such as assembly.
This change also moves asm8.s file into the right directory
so that it gets exercised by the test.
All the .s files were git-mv'd and then the ERROR comments
were changed to 'want'; also +build vet_test tags were removed.
Sadly Gerrit reports the old and new files as unrelated...
Change-Id: I8a2ecd6dd6fb0e20630f0ba6205c4378e4e912b3
Reviewed-on: https://go-review.googlesource.com/c/140120
Reviewed-by: Michael Matloob <matloob@golang.org>
Russ Cox
Alan Donovan