close_issue_1
/
tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
3,274 Commits 12 Branches 4 Tags 14 MiB
Commit Graph

3 Commits

Author SHA1 Message Date
Robert Griesemer c995a08888 go/internal/gcimporter: move 1.11 specific tests out of non-1.11 builds (fix build) 
TBR=adonovan

The tests TestImportedTypes and TestIssue25301 are dependent on many
1.11-specific bug fixes that went into go/types. Just move them out
of non-1.11 builds.

While doing so, also extended the set of test cases run by
TestImportedTypes (now matching the corresponding tests cases
in the std lib).

This also makes it again unnecessary to factor out the embeddedType
function into build-specific versions. Removed again.

For https://github.com/golang/lint/issues/402.

Change-Id: I45eb8c3d1dcca7b392f14a7660bc1599a44a0d41
Reviewed-on: https://go-review.googlesource.com/118567
Reviewed-by: Robert Griesemer <gri@golang.org>
 2018-06-13 19:12:07 +00:00
Robert Griesemer e580e344d4 go/internal/gcimporter: don't use Interface.EmbeddedType for builds before go1.11 
For https://github.com/golang/lint/issues/402.

Change-Id: I3f4eab123e52460980e76f5ffaca3a77a3af7374
Reviewed-on: https://go-review.googlesource.com/118565
Run-TryBot: Robert Griesemer <gri@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Robert Griesemer <gri@golang.org>
 2018-06-13 18:37:28 +00:00
Robert Griesemer 58c6d92c35 go/internal/gcimporter: use types.NewInterface (not NewInterface2) for builds before Go 1.11 
For https://github.com/golang/lint/issues/402.

Change-Id: If8802c93679af57bcb50c43f386f37458813d910
Reviewed-on: https://go-review.googlesource.com/118563
Run-TryBot: Robert Griesemer <gri@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
 2018-06-13 17:48:59 +00:00