tools

Commit Graph

Author	SHA1	Message	Date
Josh Bleecher Snyder	57d2ff39c7	go/ast/astutil: match prefix segments when adding imports AddImport and AddNamedImport attempt to place new imports in roughly the correct place--and thus the correct group--by matching prefixes. Matching prefixes byte-by-byte led to "regexp" being grouped with "rsc.io/p". Instead, match prefixes by segments. Fixes golang/go#9961. Change-Id: I52b7c58a9a2fbe85c2b5297e50c87d409364bda3 Reviewed-on: https://go-review.googlesource.com/8090 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>	2015-03-30 17:57:25 +00:00
Peter Collingbourne	4f8578d2c0	astutil: move to go/ast/astutil Change-Id: I9a45bfc07613eb2210081d306d71f0a4d152eda5 Reviewed-on: https://go-review.googlesource.com/2592 Reviewed-by: Alan Donovan <adonovan@google.com>	2015-01-13 15:47:47 +00:00

Author

SHA1

Message

Date

Josh Bleecher Snyder

57d2ff39c7

go/ast/astutil: match prefix segments when adding imports

AddImport and AddNamedImport attempt to place new
imports in roughly the correct place--and thus the
correct group--by matching prefixes. Matching prefixes
byte-by-byte led to "regexp" being grouped with "rsc.io/p".
Instead, match prefixes by segments.

Fixes golang/go#9961.

Change-Id: I52b7c58a9a2fbe85c2b5297e50c87d409364bda3
Reviewed-on: https://go-review.googlesource.com/8090
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

2015-03-30 17:57:25 +00:00

Peter Collingbourne

4f8578d2c0

astutil: move to go/ast/astutil

Change-Id: I9a45bfc07613eb2210081d306d71f0a4d152eda5
Reviewed-on: https://go-review.googlesource.com/2592
Reviewed-by: Alan Donovan <adonovan@google.com>

2015-01-13 15:47:47 +00:00

2 Commits