close_issue_1
/
tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
753 Commits 12 Branches 4 Tags 14 MiB
Commit Graph

5 Commits

Author SHA1 Message Date
Alan Donovan d503a640d7 go.tools/go/ssa: name anon funcs by their enclosing func. 
Before, they were named func@line:col which made them easy to find in the source if you know the file, but hard if you don't, and it made tests fragile.

Now, they are named outer$1, outer$2, etc, which makes them
more informative in a UI since "outer" has meaning.

LGTM=crawshaw
R=crawshaw
CC=golang-codereviews
https://golang.org/cl/65630048
 2014-02-28 10:18:55 -05:00
Alan Donovan 744d7e68b1 go.tools/go/ssa: use bytes.Buffer instead of io.Writer. 
This is (a) more efficient and (b) avoids the need for
constant error handling, since buffer writes can't fail.

Also:
- added WriteFunction and WritePackage functions,
  similar to types.WriteFoo.
- *Function and *Package now implement io.WriterTo.

LGTM=gri
R=gri
CC=golang-codereviews
https://golang.org/cl/57930044
 2014-01-28 17:48:10 -05:00
Alan Donovan d0efad3082 go.tools/go/ssa: use types.WriteSignature 
LGTM=gri
R=gri
CC=golang-codereviews
https://golang.org/cl/57930043
 2014-01-28 17:04:41 -05:00
Robert Griesemer ebfa4efbc4 go.tools/go/types: cleanup: more consistent exported predicate names 
Renamed predicates:
IsIdentical -> Identical
IsAssignableTo -> AssignableTo
Signature.IsVariadic -> Signature.Variadic
Object.IsExported -> Object.Exported

LGTM=adonovan
R=adonovan
CC=golang-codereviews
https://golang.org/cl/53370043
 2014-01-28 10:57:56 -08:00
Alan Donovan 3fc0fc1310 go.tools: rename packages. 
Was:		Now:
ssa		go/ssa
importer	go/loader
pointer		go/pointer

Next CL: call -> go/callgraph (requires more care)

R=gri, crawshaw
CC=golang-codereviews
https://golang.org/cl/52960043
 2014-01-16 09:33:58 -05:00