close_issue_1
/
tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
1,084 Commits 12 Branches 4 Tags 14 MiB
Commit Graph

3 Commits

Author SHA1 Message Date
Rob Pike 75b67f833e go.tools/cmd/stringer: fix generated map code 
Missed comment from previous code review.
Next up: execution tests so this won't happen again

LGTM=gri
R=gri
CC=golang-codereviews
https://golang.org/cl/134480043
 2014-09-04 16:18:38 -07:00
Rob Pike 22ede605a7 go.tools/cmd/stringer: use const for names, slice for map strings 
Improve the generated code by using a const instead of a var for the names string.
This requires some refactoring to get neat const() and var() blocks.
Also change the generate map code go use a single sliced string, to reduce the
size of the compiled representation (only one string value).

LGTM=gri
R=gri
CC=golang-codereviews
https://golang.org/cl/135450044
 2014-09-04 16:06:51 -07:00
Rob Pike 9207f67279 go.tools/cmd/stringer: add tests 
Refactor a little to make testing easier.
Add golden tests and a check fo splitIntoRuns, which is the subtlest piece.
Still to come: execution tests.

Also fix a few issues in the generated code.

LGTM=gri
R=gri
CC=golang-codereviews, josharian
https://golang.org/cl/134450044
 2014-09-04 14:16:59 -07:00