close_issue_1
/
tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

go.tools/dashboard/app: return specific error string on commit not found 

TBR=bradfitz
R=bradfitz
CC=golang-codereviews
https://golang.org/cl/153070043
This commit is contained in:
Andrew Gerrand 2014-10-06 16:28:27 +11:00
parent 51be54e32f
commit fcf4a08452
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
dashboard/app/build/handler.go
View File

@ -47,6 +47,9 @@ func commitHandler(r *http.Request) (interface{}, error) {
com.PackagePath = r.FormValue("packagePath") com.PackagePath = r.FormValue("packagePath")
com.Hash = r.FormValue("hash") com.Hash = r.FormValue("hash")
if err := datastore.Get(c, com.Key(c), com); err != nil { if err := datastore.Get(c, com.Key(c), com); err != nil {
if err == datastore.ErrNoSuchEntity {
return nil, errors.New("Commit not found")
}
return nil, fmt.Errorf("getting Commit: %v", err) return nil, fmt.Errorf("getting Commit: %v", err)
} }
if com.Num == 0 { if com.Num == 0 {