close_issue_1
/
tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

go/packages: fix broken test that checks errors 

Change-Id: Id9b1dc5e01a5b7eeca45448be0b7d7eef79fa928
Reviewed-on: https://go-review.googlesource.com/c/tools/+/172400
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
Reviewed-by: Ian Cottrell <iancottrell@google.com>
This commit is contained in:
Rebecca Stambler 2019-04-16 15:38:41 -04:00
parent 76038274be
commit f6a9ef9393
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
go/packages/packages_test.go
View File

@ -1726,9 +1726,14 @@ func testReturnErrorWhenUsingNonGoFiles(t *testing.T, exporter packagestest.Expo
}}}) }}})
defer exported.Cleanup() defer exported.Cleanup()
config := packages.Config{} config := packages.Config{}
want := "named files must be .go files"
pkgs, err := packages.Load(&config, "a/a.go", "b/b.c") pkgs, err := packages.Load(&config, "a/a.go", "b/b.c")
if err != nil { if err != nil {
t.Fatal(err) // Check if the error returned is the one we expected.
if !strings.Contains(err.Error(), want) {
t.Fatalf("want error message: %s, got: %s", want, err.Error())
}
return
} }
if len(pkgs) != 1 || pkgs[0].PkgPath != "command-line-arguments" { if len(pkgs) != 1 || pkgs[0].PkgPath != "command-line-arguments" {
t.Fatalf("packages.Load: want [command-line-arguments], got %v", pkgs) t.Fatalf("packages.Load: want [command-line-arguments], got %v", pkgs)
@ -1737,7 +1742,6 @@ func testReturnErrorWhenUsingNonGoFiles(t *testing.T, exporter packagestest.Expo
t.Fatalf("result of Load: want package with one error, got: %+v", pkgs[0]) t.Fatalf("result of Load: want package with one error, got: %+v", pkgs[0])
} }
got := pkgs[0].Errors[0].Error() got := pkgs[0].Errors[0].Error()
want := "named files must be .go files"
if !strings.Contains(got, want) { if !strings.Contains(got, want) {
t.Fatalf("want error message: %s, got: %s", want, got) t.Fatalf("want error message: %s, got: %s", want, got)
} }