From f5bb18ad35b61d4b6afef07c2634c8f21adf131e Mon Sep 17 00:00:00 2001 From: Hsin Tsao Date: Mon, 6 Feb 2017 16:07:17 -0800 Subject: [PATCH] cmd/godoc: add better user error messages Fixes golang/go#14280 Change-Id: I3151a17ce9553d0a7fe56c2d614e3a6f6a96344c Reviewed-on: https://go-review.googlesource.com/36472 Reviewed-by: Brad Fitzpatrick --- cmd/godoc/main.go | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/cmd/godoc/main.go b/cmd/godoc/main.go index 60cedf85..ec13d1a1 100644 --- a/cmd/godoc/main.go +++ b/cmd/godoc/main.go @@ -162,8 +162,15 @@ func main() { playEnabled = *showPlayground - // Check usage: either server and no args, command line and args, or index creation mode + // Check usage: server and no args. + if (*httpAddr != "" || *urlFlag != "") && (flag.NArg() > 0) { + fmt.Fprintln(os.Stderr, "can't use -http with args.") + usage() + } + + // Check usage: command line args or index creation mode. if (*httpAddr != "" || *urlFlag != "") != (flag.NArg() == 0) && !*writeIndex { + fmt.Fprintln(os.Stderr, "missing args.") usage() }