close_issue_1
/
tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

go/analysis/passes/composite: whitelist unicode.Range32 

We already whitelist unicode.Range16. This CL whitelists unicode.Range32
also, to be more consistent.

Fixes golang/go#32507

Change-Id: I72a8cf7c63845510e51c7e6ebbd3b627ecb7e0da
Reviewed-on: https://go-review.googlesource.com/c/tools/+/180922
Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
Run-TryBot: Emmanuel Odeke <emm.odeke@gmail.com>
This commit is contained in:
Tai 2019-06-10 16:34:22 +08:00 committed by Emmanuel Odeke
parent 149740340b
commit ed0dc45079
2 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
go/analysis/passes/composite/testdata/src/a/a.go vendored
View File

@ -119,3 +119,9 @@ var badNamedPointerSliceLiteral = []*unicode.CaseRange{
{1, 2, delta}, // want "unkeyed fields" {1, 2, delta}, // want "unkeyed fields"
&unicode.CaseRange{1, 2, delta}, // want "unkeyed fields" &unicode.CaseRange{1, 2, delta}, // want "unkeyed fields"
} }
// unicode.Range16 is whitelisted, so there'll be no vet error
var range16 = unicode.Range16{0xfdd0, 0xfdef, 1}
// unicode.Range32 is whitelisted, so there'll be no vet error
var range32 = unicode.Range32{0x1fffe, 0x1ffff, 1}

1
go/analysis/passes/composite/whitelist.go
View File

@ -24,6 +24,7 @@ var unkeyedLiteral = map[string]bool{
"image.Uniform": true, "image.Uniform": true,
"unicode.Range16": true, "unicode.Range16": true,
"unicode.Range32": true,
// These three structs are used in generated test main files, // These three structs are used in generated test main files,
// but the generator can be trusted. // but the generator can be trusted.