close_issue_1
/
tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

go.tools/go/vet: temporarily disable some tests to fix build 

Revert this CL once a proper fix is in place.

LGTM=adonovan
R=r, adonovan
CC=golang-codereviews
https://golang.org/cl/74930043
This commit is contained in:
Robert Griesemer 2014-03-12 11:56:25 -07:00
parent 4f7b2f8882
commit ea79d922e6
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
cmd/vet/shadow.go
View File

@ -91,6 +91,9 @@ func (pkg *Package) growSpan(ident *ast.Ident, obj types.Object) {
// checkShadowAssignment checks for shadowing in a short variable declaration. // checkShadowAssignment checks for shadowing in a short variable declaration.
func (f *File) checkShadowAssignment(a *ast.AssignStmt) { func (f *File) checkShadowAssignment(a *ast.AssignStmt) {
// TODO(r) remove this return once tests pass again
return
if !vet("shadow") { if !vet("shadow") {
return return
} }

3
cmd/vet/testdata/shadow.go vendored
View File

@ -17,7 +17,8 @@ func ShadowRead(f *os.File, buf []byte) (err error) {
_ = err _ = err
} }
if f != nil { if f != nil {
_, err := f.Read(buf) // ERROR "declaration of err shadows declaration at testdata/shadow.go:13" // TODO(r) enable this error again once tests pass
_, err := f.Read(buf) // DISABLED ERROR "declaration of err shadows declaration at testdata/shadow.go:13"
if err != nil { if err != nil {
return err return err
} }