close_issue_1
/
tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

go/vcs: add proper error handling to test. 

Fix a couple of error messages to report better messages.

R=adg
CC=golang-dev
https://golang.org/cl/13146043
This commit is contained in:
David Symonds 2013-08-21 13:55:33 +10:00
parent 373fd88c80
commit cec37cabd4
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
go/vcs/vcs_test.go
View File

@ -35,10 +35,14 @@ func TestRepoRootForImportPath(t *testing.T) {
}
for _, test := range tests {
got, _ := RepoRootForImportPath(test.path, false)
got, err := RepoRootForImportPath(test.path, false)
if err != nil {
t.Errorf("RepoRootForImport(%q): %v", test.path, err)
continue
}
want := test.want
if got.VCS.Name != want.VCS.Name || got.Repo != want.Repo {
t.Errorf("RepoRootForImport(%s) = VCS(%s) Repo(%s), want VCS(%s) Repo(%s)", test.path, got.VCS, got.Repo, want.VCS, want.Repo)
t.Errorf("RepoRootForImport(%q) = VCS(%s) Repo(%s), want VCS(%s) Repo(%s)", test.path, got.VCS, got.Repo, want.VCS, want.Repo)
}
}
}
@ -68,7 +72,7 @@ func TestFromDir(t *testing.T) {
os.MkdirAll(test.path, 0755)
got, _, _ := FromDir(test.path, tempDir)
if got.Name != test.want.Name {
t.Errorf("FromDir(%s, %s) = %s, want %s", got, test.want)
t.Errorf("FromDir(%q, %q) = %s, want %s", test.path, tempDir, got, test.want)
}
os.RemoveAll(test.path)
}