close_issue_1
/
tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

internal/span: return error when on spans with invalid starts 

Fixes golang/go#30155

Change-Id: I7f9dbec6fdfa92654f58627ef44ee4bfe2870fa6
Reviewed-on: https://go-review.googlesource.com/c/tools/+/169440
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
Reviewed-by: Ian Cottrell <iancottrell@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
This commit is contained in:
Rebecca Stambler 2019-03-26 19:48:42 -04:00
parent c02eab13f0
commit cd3f3f06fc
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
internal/span/token.go
View File

@ -65,6 +65,9 @@ func (r Range) Span() (Span, error) {
return Span{}, fmt.Errorf("file not found in FileSet") return Span{}, fmt.Errorf("file not found in FileSet")
} }
s := Span{v: span{URI: FileURI(f.Name())}} s := Span{v: span{URI: FileURI(f.Name())}}
if !r.Start.IsValid() {
return Span{}, fmt.Errorf("invalid position for start of range")
}
s.v.Start.Offset = f.Offset(r.Start) s.v.Start.Offset = f.Offset(r.Start)
if r.End.IsValid() { if r.End.IsValid() {
s.v.End.Offset = f.Offset(r.End) s.v.End.Offset = f.Offset(r.End)