close_issue_1
/
tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

go.tools/dashboard/app: remove redundant transaction 

The code is already called from inside a transaction.

TBR=dvyukov
R=dvyukov
CC=golang-codereviews
https://golang.org/cl/161580045
This commit is contained in:
Andrew Gerrand 2014-10-31 09:03:27 +11:00
parent 5d1cfb1968
commit cce262cd47
1 changed files with 16 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
dashboard/app/build/notify.go
View File

@ -200,25 +200,24 @@ var (
) )
) )
// MUST be called from inside a transaction.
func sendPerfFailMail(c appengine.Context, builder string, res *PerfResult) error { func sendPerfFailMail(c appengine.Context, builder string, res *PerfResult) error {
return datastore.RunInTransaction(c, func(c appengine.Context) error { com := &Commit{Hash: res.CommitHash}
com := &Commit{Hash: res.CommitHash} if err := datastore.Get(c, com.Key(c), com); err != nil {
if err := datastore.Get(c, com.Key(c), com); err != nil { return err
return err }
logHash := ""
parsed := res.ParseData()
for _, data := range parsed[builder] {
if !data.OK {
logHash = data.Artifacts["log"]
break
} }
logHash := "" }
parsed := res.ParseData() if logHash == "" {
for _, data := range parsed[builder] { return fmt.Errorf("can not find failed result for commit %v on builder %v", com.Hash, builder)
if !data.OK { }
logHash = data.Artifacts["log"] return commonNotify(c, com, builder, logHash)
break
}
}
if logHash == "" {
return fmt.Errorf("can not find failed result for commit %v on builder %v", com.Hash, builder)
}
return commonNotify(c, com, builder, logHash)
}, nil)
} }
// commonNotify MUST!!! be called from within a transaction inside which // commonNotify MUST!!! be called from within a transaction inside which