From ccd43c1d95a18ad3244d6973373e07bac06c6efb Mon Sep 17 00:00:00 2001 From: Andrew Gerrand Date: Fri, 14 Mar 2014 09:51:13 +1100 Subject: [PATCH] go.tools/dashboard/app: send log hash to gobot on build failure Fixes golang/go#7322. LGTM=rsc R=rsc CC=golang-codereviews https://golang.org/cl/75630043 --- dashboard/app/build/notify.go | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/dashboard/app/build/notify.go b/dashboard/app/build/notify.go index 09e484f9..44c23606 100644 --- a/dashboard/app/build/notify.go +++ b/dashboard/app/build/notify.go @@ -138,7 +138,12 @@ func updateCL(c appengine.Context, com *Commit, builder string) bool { c.Errorf("could not find CL for %v: %v", com.Hash, err) return false } - url := fmt.Sprintf("%v?cl=%v&brokebuild=%v", gobotBase, cl, builder) + res := com.Result(builder, "") + if res == nil { + c.Errorf("finding result for %q: %+v", builder, com) + return false + } + url := fmt.Sprintf("%v?cl=%v&brokebuild=%v&log=%v", gobotBase, cl, builder, res.LogHash) r, err := urlfetch.Client(c).Post(url, "text/plain", nil) if err != nil { c.Errorf("could not update CL %v: %v", cl, err)