close_issue_1
/
tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

go.tools/godoc/static: remove unnecessary mainframe wrapper 

Fixes golang/go#8300.

LGTM=adonovan
R=golang-codereviews, adonovan, bradfitz
CC=golang-codereviews
https://golang.org/cl/113130044
This commit is contained in:
Andrew Gerrand 2014-07-16 09:39:11 +10:00
parent b2ea2e8560
commit cc0b856ebe
2 changed files with 10 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
godoc/static/godoc.html
View File

@ -16,7 +16,10 @@
</head> </head>
<body> <body>
<div id="mainframe" style="position: fixed; bottom: 0; top:0; overflow: auto; width: 100%;"> <div id='lowframe' style="position: fixed; bottom: 0; left: 0; height: 0; width: 100%; border-top: thin solid grey; background-color: white; overflow: auto;">
...
</div><!-- #lowframe -->
<div id="topbar"{{if .Title}} class="wide"{{end}}><div class="container"> <div id="topbar"{{if .Title}} class="wide"{{end}}><div class="container">
<form method="GET" action="/search"> <form method="GET" action="/search">
@ -85,11 +88,6 @@ and code is licensed under a <a href="/LICENSE">BSD license</a>.<br>
</div><!-- .container --> </div><!-- .container -->
</div><!-- #page --> </div><!-- #page -->
</div><!-- #mainframe -->
<div id='lowframe' style="position: absolute; bottom: 0; left: 0; height: 0; width: 100%; border-top: thin solid grey; background-color: white; overflow: auto;">
...
</div><!-- #lowframe -->
<!-- TODO(adonovan): load these from <head> using "defer" attribute? --> <!-- TODO(adonovan): load these from <head> using "defer" attribute? -->
<script type="text/javascript" src="/lib/godoc/jquery.js"></script> <script type="text/javascript" src="/lib/godoc/jquery.js"></script>
<script type="text/javascript" src="/lib/godoc/jquery.treeview.js"></script> <script type="text/javascript" src="/lib/godoc/jquery.treeview.js"></script>

14
godoc/static/static.go
View File

@ -61,7 +61,7 @@ var Files = map[string]string{
types are assignable to each interface type. types are assignable to each interface type.
<b>Type analysis</b> is relatively quick, requiring about 10 seconds for <b>Type analysis</b> is relatively quick, requiring about 10 seconds for
the >200 packages of the standard library, for example. the &gt;200 packages of the standard library, for example.
</p> </p>
<h3>Compiler errors</h3> <h3>Compiler errors</h3>
@ -149,7 +149,7 @@ var Files = map[string]string{
</p> </p>
<p> <p>
In this example, hovering over the declaration of the In this example, hovering over the declaration of the
<code>rot13</code> function (defined in in strings/strings.test.go) <code>rot13</code> function (defined in strings/strings_test.go)
reveals that it is called in exactly one place. reveals that it is called in exactly one place.
</p> </p>
<img class="ss" width='612' src='callers1.png'> <img class="ss" width='612' src='callers1.png'>
@ -485,7 +485,10 @@ var Files = map[string]string{
</head> </head>
<body> <body>
<div id="mainframe" style="position: fixed; bottom: 0; top:0; overflow: auto; width: 100%;"> <div id='lowframe' style="position: fixed; bottom: 0; left: 0; height: 0; width: 100%; border-top: thin solid grey; background-color: white; overflow: auto;">
...
</div><!-- #lowframe -->
<div id="topbar"{{if .Title}} class="wide"{{end}}><div class="container"> <div id="topbar"{{if .Title}} class="wide"{{end}}><div class="container">
<form method="GET" action="/search"> <form method="GET" action="/search">
@ -554,11 +557,6 @@ and code is licensed under a <a href="/LICENSE">BSD license</a>.<br>
</div><!-- .container --> </div><!-- .container -->
</div><!-- #page --> </div><!-- #page -->
</div><!-- #mainframe -->
<div id='lowframe' style="position: absolute; bottom: 0; left: 0; height: 0; width: 100%; border-top: thin solid grey; background-color: white; overflow: auto;">
...
</div><!-- #lowframe -->
<!-- TODO(adonovan): load these from <head> using "defer" attribute? --> <!-- TODO(adonovan): load these from <head> using "defer" attribute? -->
<script type="text/javascript" src="/lib/godoc/jquery.js"></script> <script type="text/javascript" src="/lib/godoc/jquery.js"></script>
<script type="text/javascript" src="/lib/godoc/jquery.treeview.js"></script> <script type="text/javascript" src="/lib/godoc/jquery.treeview.js"></script>