From cadb821a95df0e7ef6343c3d16d13d53e8f9a9d6 Mon Sep 17 00:00:00 2001 From: Alan Donovan Date: Mon, 15 Feb 2016 15:48:08 -0500 Subject: [PATCH] cmd/guru: don't panic on *ast.Bad{Decl,Stmt,Expr} These nodes are common in incomplete programs. Change-Id: Iff9750050c78762f0cb8bebc7739584c197d661e Reviewed-on: https://go-review.googlesource.com/19509 Reviewed-by: Michael Matloob --- go/ast/astutil/enclosing.go | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/go/ast/astutil/enclosing.go b/go/ast/astutil/enclosing.go index 2de739ef..340c9e6c 100644 --- a/go/ast/astutil/enclosing.go +++ b/go/ast/astutil/enclosing.go @@ -447,9 +447,8 @@ func childrenOf(n ast.Node) []ast.Node { case *ast.ValueSpec: // TODO(adonovan): ValueSpec.{Doc,Comment}? - default: - // Includes *ast.BadDecl, *ast.BadExpr, *ast.BadStmt. - panic(fmt.Sprintf("unexpected node type %T", n)) + case *ast.BadDecl, *ast.BadExpr, *ast.BadStmt: + // nop } // TODO(adonovan): opt: merge the logic of ast.Inspect() into