From c930a8531daf66d01ce069cc6b196eb98fe1138b Mon Sep 17 00:00:00 2001 From: Michael Matloob Date: Tue, 2 Oct 2018 15:34:24 -0400 Subject: [PATCH] go/packages: remove code that skips two tests for Go 1.10 TestLoadImportsC just works on Go 1.10. And there's no good reason that TestLoadAllSyntaxImportErrors shouldn't work, even though it's currently always skipped. Change-Id: Icd8d311f12c5731cc635937a00251eab0a3077ec Reviewed-on: https://go-review.googlesource.com/139117 Reviewed-by: Alan Donovan --- go/packages/packages_test.go | 7 ------- 1 file changed, 7 deletions(-) diff --git a/go/packages/packages_test.go b/go/packages/packages_test.go index ff485e7b..77874de9 100644 --- a/go/packages/packages_test.go +++ b/go/packages/packages_test.go @@ -296,9 +296,6 @@ func TestLoadImportsC(t *testing.T) { // See https://github.com/golang/go/issues/27100. t.Skip(`skipping on plan9; for some reason "net [syscall.test]" is not loaded`) } - if usesOldGolist { - t.Skip("not yet supported in pre-Go 1.10.4 golist fallback implementation") - } cfg := &packages.Config{ Mode: packages.LoadImports, @@ -881,10 +878,6 @@ func TestLoadAllSyntaxImportErrors(t *testing.T) { // TODO(matloob): Remove this once go list -e -compiled is fixed. See golang.org/issue/26755 t.Skip("go list -compiled -e fails with non-zero exit status for empty packages") - if usesOldGolist { - t.Skip("not yet supported in pre-Go 1.10.4 golist fallback implementation") - } - tmp, cleanup := makeTree(t, map[string]string{ "src/unicycle/unicycle.go": `package unicycle; import _ "unicycle"`, "src/bicycle1/bicycle1.go": `package bicycle1; import _ "bicycle2"`,