close_issue_1
/
tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

go/analysis/internal/checker: fix go1.10 build 

...by removing references to trace API for now.

Change-Id: Ide6bbbfd98e15a3773b4a10232bcbf2dc2153341
Reviewed-on: https://go-review.googlesource.com/137615
Reviewed-by: Alan Donovan <adonovan@google.com>
This commit is contained in:
Alan Donovan 2018-09-26 09:05:57 -04:00
parent 9eb9690e39
commit c756801b01
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
go/analysis/internal/checker/checker.go
View File

@ -6,7 +6,6 @@ package checker
import ( import (
"bytes" "bytes"
"context"
"encoding/gob" "encoding/gob"
"encoding/json" "encoding/json"
"flag" "flag"
@ -442,9 +441,13 @@ func (act *action) execOnce() {
// Analyze dependencies. // Analyze dependencies.
execAll(act.deps) execAll(act.deps)
ctx, task := trace.NewTask(context.Background(), "exec") // TODO(adonovan): uncomment this during profiling.
defer task.End() // It won't build pre-go1.11 but conditional compilation
trace.Log(ctx, "pass", act.String()) // using build tags isn't warranted.
//
// ctx, task := trace.NewTask(context.Background(), "exec")
// trace.Log(ctx, "pass", act.String())
// defer task.End()
// Record time spent in this node but not its dependencies. // Record time spent in this node but not its dependencies.
// In parallel mode, due to GC/scheduler contention, the // In parallel mode, due to GC/scheduler contention, the