close_issue_1
/
tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

go.tools/dashboard: update existing results when builder retries a commit 

LGTM=adg
R=adg
CC=golang-codereviews
https://golang.org/cl/96360047
This commit is contained in:
Chris Manghane 2014-05-19 09:51:04 -07:00
parent a8c8f48be3
commit c309b30e41
1 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
dashboard/app/build/build.go
View File

@ -101,6 +101,7 @@ type Commit struct {
Desc string `datastore:",noindex"` Desc string `datastore:",noindex"`
Time time.Time Time time.Time
NeedsBenchmarking bool NeedsBenchmarking bool
TryPatch bool
// ResultData is the Data string of each build Result for this Commit. // ResultData is the Data string of each build Result for this Commit.
// For non-Go commits, only the Results for the current Go tip, weekly, // For non-Go commits, only the Results for the current Go tip, weekly,
@ -144,7 +145,19 @@ func (com *Commit) AddResult(c appengine.Context, r *Result) error {
if err := datastore.Get(c, com.Key(c), com); err != nil { if err := datastore.Get(c, com.Key(c), com); err != nil {
return fmt.Errorf("getting Commit: %v", err) return fmt.Errorf("getting Commit: %v", err)
} }
var resultExists bool
for i, s := range com.ResultData {
// if there already exists result data for this builder at com, overwrite it.
if strings.Contains(s, r.Builder) {
resultExists = true
com.ResultData[i] = r.Data()
}
}
if !resultExists {
// otherwise, add the new result data for this builder.
com.ResultData = trim(append(com.ResultData, r.Data()), maxResults) com.ResultData = trim(append(com.ResultData, r.Data()), maxResults)
}
if _, err := datastore.Put(c, com.Key(c), com); err != nil { if _, err := datastore.Put(c, com.Key(c), com); err != nil {
return fmt.Errorf("putting Commit: %v", err) return fmt.Errorf("putting Commit: %v", err)
} }