From c1a832b0ad89ed14aba1b0a13a0733e291a7c7fc Mon Sep 17 00:00:00 2001 From: Michael Matloob Date: Fri, 22 Mar 2019 16:28:41 -0400 Subject: [PATCH] go/packages: remove spurious print Also fix a test name. Fixes golang/go#30994 Change-Id: Ib37359254206ecf47b0ac23098c57da1e69944a1 Reviewed-on: https://go-review.googlesource.com/c/tools/+/168939 Run-TryBot: Michael Matloob Reviewed-by: Brad Fitzpatrick TryBot-Result: Gobot Gobot --- go/packages/golist.go | 1 - go/packages/packages_test.go | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/go/packages/golist.go b/go/packages/golist.go index 4035086e..bbf7343f 100644 --- a/go/packages/golist.go +++ b/go/packages/golist.go @@ -761,7 +761,6 @@ func invokeGo(cfg *Config, args ...string) (*bytes.Buffer, error) { if len(stderr.String()) > 0 && strings.Contains(stderr.String(), "named files must be .go files") { output := fmt.Sprintf(`{"ImportPath": "","Incomplete": true,"Error": {"Pos": "","Err": %s}}`, strconv.Quote(strings.Trim(stderr.String(), "\n"))) - fmt.Println(output) return bytes.NewBufferString(output), nil } diff --git a/go/packages/packages_test.go b/go/packages/packages_test.go index 4424090f..c9e09655 100644 --- a/go/packages/packages_test.go +++ b/go/packages/packages_test.go @@ -313,7 +313,7 @@ func TestLoadAbsolutePath(t *testing.T) { } } -func TestReturnErrorWhenUsingNoneGoFiles(t *testing.T) { +func TestReturnErrorWhenUsingNonGoFiles(t *testing.T) { exported := packagestest.Export(t, packagestest.GOPATH, []packagestest.Module{{ Name: "golang.org/gopatha", Files: map[string]interface{}{