close_issue_1
/
tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

go.tools/imports: recognize exports in cgo files 

Fixes golang/go#8815.

LGTM=bradfitz
R=bradfitz
CC=golang-codereviews
https://golang.org/cl/143660044
This commit is contained in:
Josh Bleecher Snyder 2014-09-29 12:46:11 -07:00 committed by Brad Fitzpatrick
parent e62e5f9885
commit b6c30b58fc
1 changed files with 11 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
imports/fix.go
View File

@ -283,15 +283,17 @@ func loadExportsGoPath(dir string) map[string]bool {
return nil return nil
} }
fset := token.NewFileSet() fset := token.NewFileSet()
for _, file := range buildPkg.GoFiles { for _, files := range [...][]string{buildPkg.GoFiles, buildPkg.CgoFiles} {
f, err := parser.ParseFile(fset, filepath.Join(dir, file), nil, 0) for _, file := range files {
if err != nil { f, err := parser.ParseFile(fset, filepath.Join(dir, file), nil, 0)
fmt.Fprintf(os.Stderr, "could not parse %q: %v\n", file, err) if err != nil {
continue fmt.Fprintf(os.Stderr, "could not parse %q: %v\n", file, err)
} continue
for name := range f.Scope.Objects { }
if ast.IsExported(name) { for name := range f.Scope.Objects {
exports[name] = true if ast.IsExported(name) {
exports[name] = true
}
} }
} }
} }