close_issue_1
/
tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

internal/lsp: block rather than reject when the message queue is full 

Change-Id: Ic8d4a0a4abfed71fe9290e9aae4efd6ab55124d5
Reviewed-on: https://go-review.googlesource.com/c/tools/+/182458
Run-TryBot: Ian Cottrell <iancottrell@google.com>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
This commit is contained in:
Ian Cottrell 2019-06-14 13:17:16 -04:00
parent d1d6cdd8a6
commit a82f0323a4
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
internal/lsp/protocol/protocol.go
View File

@ -12,6 +12,7 @@ import (
) )
const defaultMessageBufferSize = 20 const defaultMessageBufferSize = 20
const defaultRejectIfOverloaded = false
func canceller(ctx context.Context, conn *jsonrpc2.Conn, req *jsonrpc2.Request) { func canceller(ctx context.Context, conn *jsonrpc2.Conn, req *jsonrpc2.Request) {
conn.Notify(context.Background(), "$/cancelRequest", &CancelParams{ID: *req.ID}) conn.Notify(context.Background(), "$/cancelRequest", &CancelParams{ID: *req.ID})
@ -21,7 +22,7 @@ func NewClient(stream jsonrpc2.Stream, client Client) (*jsonrpc2.Conn, Server, x
log := xlog.New(NewLogger(client)) log := xlog.New(NewLogger(client))
conn := jsonrpc2.NewConn(stream) conn := jsonrpc2.NewConn(stream)
conn.Capacity = defaultMessageBufferSize conn.Capacity = defaultMessageBufferSize
conn.RejectIfOverloaded = true conn.RejectIfOverloaded = defaultRejectIfOverloaded
conn.Handler = clientHandler(log, client) conn.Handler = clientHandler(log, client)
conn.Canceler = jsonrpc2.Canceler(canceller) conn.Canceler = jsonrpc2.Canceler(canceller)
return conn, &serverDispatcher{Conn: conn}, log return conn, &serverDispatcher{Conn: conn}, log
@ -32,7 +33,7 @@ func NewServer(stream jsonrpc2.Stream, server Server) (*jsonrpc2.Conn, Client, x
client := &clientDispatcher{Conn: conn} client := &clientDispatcher{Conn: conn}
log := xlog.New(NewLogger(client)) log := xlog.New(NewLogger(client))
conn.Capacity = defaultMessageBufferSize conn.Capacity = defaultMessageBufferSize
conn.RejectIfOverloaded = true conn.RejectIfOverloaded = defaultRejectIfOverloaded
conn.Handler = serverHandler(log, server) conn.Handler = serverHandler(log, server)
conn.Canceler = jsonrpc2.Canceler(canceller) conn.Canceler = jsonrpc2.Canceler(canceller)
return conn, client, log return conn, client, log