close_issue_1
/
tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

go.tools/imports: use same logic as 'go' tool for pruning package search. 

The previous logic would descend into "_"-prefixed names, "testdata" folders,
and skipped folders beginning with a digit.

Fixes golang/go#8958.

LGTM=bradfitz
R=golang-codereviews, dave, bradfitz
CC=golang-codereviews
https://golang.org/cl/167000043
This commit is contained in:
Dmitri Shuralyov 2014-11-12 12:45:17 -08:00 committed by Brad Fitzpatrick
parent c097262a24
commit a26eca502f
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
imports/fix.go
View File

@ -239,11 +239,9 @@ func loadPkg(wg *sync.WaitGroup, root, pkgrelpath string) {
// then the calls to importPathToName below can be expensive. // then the calls to importPathToName below can be expensive.
hasGo := false hasGo := false
for _, child := range children { for _, child := range children {
// Avoid .foo, _foo, and testdata directory trees.
name := child.Name() name := child.Name()
if name == "" { if name == "" || name[0] == '.' || name[0] == '_' || name == "testdata" {
continue
}
if c := name[0]; c == '.' || ('0' <= c && c <= '9') {
continue continue
} }
if strings.HasSuffix(name, ".go") { if strings.HasSuffix(name, ".go") {