close_issue_1
/
tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

go.tools: various doc fixes. 

LGTM=crawshaw
R=gri, crawshaw
CC=golang-codereviews
https://golang.org/cl/91420044
This commit is contained in:
Alan Donovan 2014-07-10 07:24:52 -04:00
parent 400db89b86
commit a16d58355f
2 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
go/ssa/builder.go
View File

@ -529,6 +529,7 @@ func (b *builder) expr0(fn *Function, e ast.Expr) Value {
// &*p must panic if p is nil (http://golang.org/s/go12nil). // &*p must panic if p is nil (http://golang.org/s/go12nil).
// For simplicity, we'll just (suboptimally) rely // For simplicity, we'll just (suboptimally) rely
// on the side effects of a load. // on the side effects of a load.
// TODO(adonovan): emit dedicated nilcheck.
addr.load(fn) addr.load(fn)
} }
return addr.address(fn) return addr.address(fn)
@ -1563,7 +1564,7 @@ func (b *builder) forStmt(fn *Function, s *ast.ForStmt, label *lblock) {
fn.currentBlock = done fn.currentBlock = done
} }
// rangeIndexed emits to fn the header for an integer indexed loop // rangeIndexed emits to fn the header for an integer-indexed loop
// over array, *array or slice value x. // over array, *array or slice value x.
// The v result is defined only if tv is non-nil. // The v result is defined only if tv is non-nil.
// //
@ -2079,7 +2080,7 @@ func (b *builder) buildFunction(fn *Function) {
// Control fell off the end of the function's body block. // Control fell off the end of the function's body block.
// //
// Block optimizations eliminate the current block, if // Block optimizations eliminate the current block, if
// unreachable. It is an ssa.builder invariant that // unreachable. It is a builder invariant that
// if this no-arg return is ill-typed for // if this no-arg return is ill-typed for
// fn.Signature.Results, this block must be // fn.Signature.Results, this block must be
// unreachable. The sanity checker checks this. // unreachable. The sanity checker checks this.

2
go/ssa/ssa.go
View File

@ -264,8 +264,6 @@ type Node interface {
// will be nil too. Clients performing whole-program analysis must // will be nil too. Clients performing whole-program analysis must
// handle external functions specially. // handle external functions specially.
// //
// Functions are immutable values; they do not have addresses.
//
// Blocks contains the function's control-flow graph (CFG). // Blocks contains the function's control-flow graph (CFG).
// Blocks[0] is the function entry point; block order is not otherwise // Blocks[0] is the function entry point; block order is not otherwise
// semantically significant, though it may affect the readability of // semantically significant, though it may affect the readability of