From 9c8c5aeafa05ca9c7edb0f32e24955a9236a61ed Mon Sep 17 00:00:00 2001 From: Yasuhiro Matsumoto Date: Thu, 21 Feb 2019 09:26:10 +0900 Subject: [PATCH] internal/lsp/cache: skip duplicate import of packages Change-Id: I33e06b53269cef7aa8962dd41ea74ce25e82fc54 Reviewed-on: https://go-review.googlesource.com/c/163257 Reviewed-by: Rebecca Stambler Run-TryBot: Rebecca Stambler TryBot-Result: Gobot Gobot --- internal/lsp/cache/view.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/internal/lsp/cache/view.go b/internal/lsp/cache/view.go index 01b533c0..8c719ead 100644 --- a/internal/lsp/cache/view.go +++ b/internal/lsp/cache/view.go @@ -197,6 +197,9 @@ type entry struct { } func (imp *importer) addImports(path string, pkg *packages.Package) error { + if _, ok := imp.packages[path]; ok { + return nil + } imp.packages[path] = pkg for importPath, importPkg := range pkg.Imports { if err := imp.addImports(importPath, importPkg); err != nil {