close_issue_1
/
tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

cmd/vet: don't panic if import fails 

Initializing the unused variable formatterType (it will be used soon) was
panicking if the import couldn't be done, but vet shouldn't be so fragile.

LGTM=gri
R=gri
CC=dsymonds, golang-codereviews
https://golang.org/cl/153480044
This commit is contained in:
Rob Pike 2014-10-14 12:55:46 -07:00
parent b45b275b99
commit 9be0b38f5b
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
cmd/vet/types.go
View File

@ -20,10 +20,17 @@ var imports = make(map[string]*types.Package)
var ( var (
stringerMethodType = types.New("func() string") stringerMethodType = types.New("func() string")
errorType = types.New("error").Underlying().(*types.Interface) errorType = types.New("error").Underlying().(*types.Interface)
stringerType = importType("fmt", "Stringer").Underlying().(*types.Interface) stringerType = types.New("interface{ String() string }").(*types.Interface)
formatterType = importType("fmt", "Formatter").Underlying().(*types.Interface) formatterType *types.Interface
) )
func init() {
typ := importType("fmt", "Formatter")
if typ != nil {
formatterType = typ.Underlying().(*types.Interface)
}
}
// importType returns the type denoted by the qualified identifier // importType returns the type denoted by the qualified identifier
// path.name, and adds the respective package to the imports map // path.name, and adds the respective package to the imports map
// as a side effect. // as a side effect.