close_issue_1
/
tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

cmd/callgraph: update flag docstring 

And add a TODO.

Change-Id: I51c63b32e9ac4309cdfb8228348a5d528f36a919
Reviewed-on: https://go-review.googlesource.com/10489
Reviewed-by: Robert Griesemer <gri@golang.org>
This commit is contained in:
Alan Donovan 2015-05-29 12:33:10 -04:00
parent 9c7ccd869c
commit 8ccf558e8a
2 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cmd/callgraph/main.go
View File

@ -42,7 +42,7 @@ import (
) )
var algoFlag = flag.String("algo", "rta", var algoFlag = flag.String("algo", "rta",
`Call graph construction algorithm, one of "rta" or "pta"`) `Call graph construction algorithm (static, cha, rta, pta)`)
var testFlag = flag.Bool("test", false, var testFlag = flag.Bool("test", false,
"Loads test code (*_test.go) for imported packages") "Loads test code (*_test.go) for imported packages")

2
go/callgraph/static/static.go
View File

@ -15,6 +15,8 @@ func CallGraph(prog *ssa.Program) *callgraph.Graph {
cg := callgraph.New(nil) // TODO(adonovan) eliminate concept of rooted callgraph cg := callgraph.New(nil) // TODO(adonovan) eliminate concept of rooted callgraph
// TODO(adonovan): opt: use only a single pass over the ssa.Program. // TODO(adonovan): opt: use only a single pass over the ssa.Program.
// TODO(adonovan): opt: this is slower than RTA (perhaps because
// the lower precision means so many edges are allocated)!
for f := range ssautil.AllFunctions(prog) { for f := range ssautil.AllFunctions(prog) {
fnode := cg.CreateNode(f) fnode := cg.CreateNode(f)
for _, b := range f.Blocks { for _, b := range f.Blocks {