From 8bc39b98806018cdd1163c436250fa9b8048f834 Mon Sep 17 00:00:00 2001 From: Ian Cottrell Date: Fri, 7 Dec 2018 13:29:09 -0500 Subject: [PATCH] go/packages: an empty overlay does not force source mode we check length of the map, and a non empty map forces source mode. Change-Id: Id314ad87b96d9154198122586fd8672a70c5ca95 Reviewed-on: https://go-review.googlesource.com/c/153198 Run-TryBot: Ian Cottrell Reviewed-by: Michael Matloob TryBot-Result: Gobot Gobot --- go/packages/packages.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/go/packages/packages.go b/go/packages/packages.go index 81e5b82e..7a4c9429 100644 --- a/go/packages/packages.go +++ b/go/packages/packages.go @@ -432,7 +432,7 @@ func (ld *loader) refine(roots []string, list ...*Package) ([]*Package, error) { ld.Mode >= LoadTypes && rootIndex >= 0, needsrc: ld.Mode >= LoadAllSyntax || ld.Mode >= LoadSyntax && rootIndex >= 0 || - ld.Overlay != nil || // Overlays can invalidate export data. TODO(matloob): make this check fine-grained based on dependencies on overlaid files + len(ld.Overlay) > 0 || // Overlays can invalidate export data. TODO(matloob): make this check fine-grained based on dependencies on overlaid files pkg.ExportFile == "" && pkg.PkgPath != "unsafe", } ld.pkgs[lpkg.ID] = lpkg