close_issue_1
/
tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

go.tools/dashboard/app: update bad builder list 

LGTM=r
R=r, minux.ma
CC=golang-codereviews
https://golang.org/cl/57580043
This commit is contained in:
Andrew Gerrand 2014-01-28 17:59:29 +11:00
parent 5cb6365d33
commit 8aae138131
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
dashboard/app/build/notify.go
View File

@ -30,11 +30,13 @@ const (
gobotBase = "http://research.swtch.com/gobot_codereview" gobotBase = "http://research.swtch.com/gobot_codereview"
) )
// failIgnore is a set of builders that we don't email about because // ignoreFailure is a set of builders that we don't email about because
// they're too flaky. // they are not yet production-ready.
var failIgnore = map[string]bool{ var ignoreFailure = map[string]bool{
"netbsd-386-bsiegert": true, "dragonfly-amd64": true,
"netbsd-amd64-bsiegert": true, "netbsd-amd64-bsiegert": true,
"plan-386-cnielsen": true,
"solaris-amd64-smartos": true,
} }
// notifyOnFailure checks whether the supplied Commit or the subsequent // notifyOnFailure checks whether the supplied Commit or the subsequent
@ -46,7 +48,7 @@ var failIgnore = map[string]bool{
// This must be run in a datastore transaction, and the provided *Commit must // This must be run in a datastore transaction, and the provided *Commit must
// have been retrieved from the datastore within that transaction. // have been retrieved from the datastore within that transaction.
func notifyOnFailure(c appengine.Context, com *Commit, builder string) error { func notifyOnFailure(c appengine.Context, com *Commit, builder string) error {
if failIgnore[builder] { if ignoreFailure[builder] {
return nil return nil
} }