From 8a44e74612bcf51f0d4407df3d3a8377cb99c2d8 Mon Sep 17 00:00:00 2001 From: Brad Fitzpatrick Date: Wed, 3 Apr 2019 17:40:56 +0000 Subject: [PATCH] go/packages: only test TestSizes on GOOS where 386 and amd64 GOARCH exists Fixes solaris/amd64 about missing solaris/386, which isn't a supported port: https://build.golang.org/log/39bfb29694089b7aaa6d0a60cc9bd3360129c2ab Change-Id: If6d9fb368f3236ccf461d5ec47ad3ff4b7ef55b6 Reviewed-on: https://go-review.googlesource.com/c/tools/+/170619 Run-TryBot: Brad Fitzpatrick TryBot-Result: Gobot Gobot Reviewed-by: Michael Matloob --- go/packages/packages_test.go | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/go/packages/packages_test.go b/go/packages/packages_test.go index 0421cfbf..d3e22504 100644 --- a/go/packages/packages_test.go +++ b/go/packages/packages_test.go @@ -1169,6 +1169,13 @@ func testContainsOverlay(t *testing.T, exporter packagestest.Exporter) { // too report the correct sizes function for the actual configuration. func TestSizes(t *testing.T) { packagestest.TestAll(t, testSizes) } func testSizes(t *testing.T, exporter packagestest.Exporter) { + // Only run this test on operating systems that have both an amd64 and 386 port. + switch runtime.GOOS { + case "darwin", "linux", "windows", "freebsd", "openbsd", "android": + default: + t.Skipf("skipping test on %s", runtime.GOOS) + } + exported := packagestest.Export(t, exporter, []packagestest.Module{{ Name: "golang.org/fake", Files: map[string]interface{}{