close_issue_1
/
tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor/rename: require cl-lib, use cl- namespace 

go-rename.el used the cl list* macro without requiring cl. This only
worked for people who required it for other code. go-guru.el, before its
removal from the tree, changed from cl to cl-lib, indirectly breaking
go-rename.el for some users.

Switch to using cl-list* and require cl-lib.

Fixes golang/go#17468

Change-Id: I70f2052b9fd3d1a8671794d9a3954be218026af2
Reviewed-on: https://go-review.googlesource.com/31471
Reviewed-by: Alan Donovan <adonovan@google.com>
This commit is contained in:
Dominik Honnef 2016-10-19 18:14:54 +02:00 committed by Alan Donovan
parent af95c112ad
commit 860883f6da
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
refactor/rename/go-rename.el
View File

@ -21,6 +21,7 @@
;;; Code: ;;; Code:
(require 'cl-lib)
(require 'compile) (require 'compile)
(require 'go-mode) (require 'go-mode)
(require 'thingatpt) (require 'thingatpt)
@ -67,7 +68,7 @@ the `gorename' tool. With FORCE, call `gorename' with the
(message "Command: %s:" args) (message "Command: %s:" args)
(message "Running gorename...") (message "Running gorename...")
;; Use dynamic binding to modify/restore the environment ;; Use dynamic binding to modify/restore the environment
(setq success (zerop (let ((process-environment (list* goroot-env gopath-env process-environment))) (setq success (zerop (let ((process-environment (cl-list* goroot-env gopath-env process-environment)))
(apply #'call-process args)))) (apply #'call-process args))))
(insert "\n") (insert "\n")
(compilation-mode) (compilation-mode)