close_issue_1
/
tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

go/ssa: updated inconsistent docs after Program.Method rename 

Fixes golang/go#20225

Change-Id: Ifd069546698981f3c6a3673dd73a1bd770560f8b
Reviewed-on: https://go-review.googlesource.com/c/42570
Reviewed-by: Alan Donovan <adonovan@google.com>
This commit is contained in:
Nicholas Ng 2017-05-03 23:14:54 +01:00 committed by Alan Donovan
parent 84d77ece31
commit 8542fc29bd
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
go/ssa/methods.go
View File

@ -23,14 +23,14 @@ import (
// //
func (prog *Program) MethodValue(sel *types.Selection) *Function { func (prog *Program) MethodValue(sel *types.Selection) *Function {
if sel.Kind() != types.MethodVal { if sel.Kind() != types.MethodVal {
panic(fmt.Sprintf("Method(%s) kind != MethodVal", sel)) panic(fmt.Sprintf("MethodValue(%s) kind != MethodVal", sel))
} }
T := sel.Recv() T := sel.Recv()
if isInterface(T) { if isInterface(T) {
return nil // abstract method return nil // abstract method
} }
if prog.mode&LogSource != 0 { if prog.mode&LogSource != 0 {
defer logStack("Method %s %v", T, sel)() defer logStack("MethodValue %s %v", T, sel)()
} }
prog.methodsMu.Lock() prog.methodsMu.Lock()

2
go/ssa/ssa.go
View File

@ -654,7 +654,7 @@ type ChangeInterface struct {
// value of a concrete type. // value of a concrete type.
// //
// Use Program.MethodSets.MethodSet(X.Type()) to find the method-set // Use Program.MethodSets.MethodSet(X.Type()) to find the method-set
// of X, and Program.Method(m) to find the implementation of a method. // of X, and Program.MethodValue(m) to find the implementation of a method.
// //
// To construct the zero value of an interface type T, use: // To construct the zero value of an interface type T, use:
// NewConst(constant.MakeNil(), T, pos) // NewConst(constant.MakeNil(), T, pos)