go.tools/go/types: handle embedded interfaces in NewInterface

R=gri
CC=golang-dev
https://golang.org/cl/39040043

go/types/types.go

@@ -273,11 +273,29 @@ func NewInterface(methods []*Func, types []*Named) *Interface {
 	}
 	sort.Sort(byUniqueMethodName(methods))
 
-	if types != nil {
+	var allMethods []*Func
-		panic("unimplemented")
+	if types == nil {
+		allMethods = methods
+	} else {
+		allMethods = append(allMethods, methods...)
+		for _, t := range types {
+			it := t.Underlying().(*Interface)
+			for _, tm := range it.allMethods {
+				// Make a copy of the method and adjust its receiver type.
+				newm := *tm
+				newmtyp := *tm.typ.(*Signature)
+				newm.typ = &newmtyp
+				newmtyp.recv = NewVar(newm.pos, newm.pkg, "", typ)
+				allMethods = append(allMethods, &newm)
+			}
+		}
+		sort.Sort(byUniqueMethodName(allMethods))
 	}
 
-	return &Interface{methods: methods, allMethods: methods}
+	typ.methods = methods
+	typ.types = types
+	typ.allMethods = allMethods
+	return typ
 }
 
 // NumMethods returns the number of methods of interface t.