close_issue_1
/
tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

go/analysis/analysistest: refuse to analyze zero packages 

It's easy to forget to pass the last argument,
in which case the test would silently pass.

Change-Id: I95249e1fe8bee75cfaa535fcf723d04f102214fc
Reviewed-on: https://go-review.googlesource.com/138395
Reviewed-by: Michael Matloob <matloob@golang.org>
This commit is contained in:
Alan Donovan 2018-09-28 09:02:09 -04:00
parent ae8529dc16
commit 7b71b077e1
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
go/analysis/analysistest/analysistest.go
View File

@ -66,6 +66,9 @@ type Testing interface {
// You may wish to call this function from within a (*testing.T).Run // You may wish to call this function from within a (*testing.T).Run
// subtest to ensure that errors have adequate contextual description. // subtest to ensure that errors have adequate contextual description.
func Run(t Testing, dir string, a *analysis.Analyzer, pkgnames ...string) { func Run(t Testing, dir string, a *analysis.Analyzer, pkgnames ...string) {
if pkgnames == nil {
t.Errorf("Run: no packages")
}
for _, pkgname := range pkgnames { for _, pkgname := range pkgnames {
pkg, err := loadPackage(dir, pkgname) pkg, err := loadPackage(dir, pkgname)
if err != nil { if err != nil {