From 76038274be7a01841c956b392153ceea3758f3ab Mon Sep 17 00:00:00 2001 From: Rebecca Stambler Date: Tue, 16 Apr 2019 15:03:58 -0400 Subject: [PATCH] internal/lsp: fix badly formatted error messages from go vet Fixes golang/go#31494 Change-Id: Id65e0daaa67a9fe955b7586af82e4433762cd56c Reviewed-on: https://go-review.googlesource.com/c/tools/+/172398 Run-TryBot: Rebecca Stambler Reviewed-by: Ian Cottrell --- internal/lsp/source/diagnostics.go | 3 +-- internal/lsp/testdata/analyzer/bad_test.go | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/internal/lsp/source/diagnostics.go b/internal/lsp/source/diagnostics.go index 9e35cb39..6c76670c 100644 --- a/internal/lsp/source/diagnostics.go +++ b/internal/lsp/source/diagnostics.go @@ -112,11 +112,10 @@ func Diagnostics(ctx context.Context, v View, uri span.URI) (map[span.URI][]Diag if diag.Category != "" { category += "." + category } - reports[s.URI()] = append(reports[s.URI()], Diagnostic{ Source: category, Span: s, - Message: fmt.Sprintf(diag.Message), + Message: diag.Message, Severity: SeverityWarning, }) }) diff --git a/internal/lsp/testdata/analyzer/bad_test.go b/internal/lsp/testdata/analyzer/bad_test.go index d10ff813..823eeca4 100644 --- a/internal/lsp/testdata/analyzer/bad_test.go +++ b/internal/lsp/testdata/analyzer/bad_test.go @@ -10,7 +10,7 @@ func Testbad(t *testing.T) { //@diag("", "tests", "Testbad has malformed name: f var x sync.Mutex _ = x //@diag("x", "copylocks", "assignment copies lock value to _: sync.Mutex") - printfWrapper("%s") //@diag("printfWrapper", "printf", "printfWrapper format %!s(MISSING) reads arg #1, but call has 0 args") + printfWrapper("%s") //@diag("printfWrapper", "printf", "printfWrapper format %s reads arg #1, but call has 0 args") } func printfWrapper(format string, args ...interface{}) {