close_issue_1
/
tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

go.tools/cmd/stringer: fix generated map code 

Missed comment from previous code review.
Next up: execution tests so this won't happen again

LGTM=gri
R=gri
CC=golang-codereviews
https://golang.org/cl/134480043
This commit is contained in:
Rob Pike 2014-09-04 16:18:38 -07:00
parent 22ede605a7
commit 75b67f833e
2 changed files with 14 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
cmd/stringer/golden_test.go
View File

@ -232,19 +232,19 @@ const map_out = `
const _Prime_name = "p2p3p5p7p11p13p17p19p23p29p37p41p43" const _Prime_name = "p2p3p5p7p11p13p17p19p23p29p37p41p43"
var _Prime_map = map[Prime]string{ var _Prime_map = map[Prime]string{
2: _Prime_map[0:2], 2: _Prime_name[0:2],
3: _Prime_map[2:4], 3: _Prime_name[2:4],
5: _Prime_map[4:6], 5: _Prime_name[4:6],
7: _Prime_map[6:8], 7: _Prime_name[6:8],
11: _Prime_map[8:11], 11: _Prime_name[8:11],
13: _Prime_map[11:14], 13: _Prime_name[11:14],
17: _Prime_map[14:17], 17: _Prime_name[14:17],
19: _Prime_map[17:20], 19: _Prime_name[17:20],
23: _Prime_map[20:23], 23: _Prime_name[20:23],
29: _Prime_map[23:26], 29: _Prime_name[23:26],
31: _Prime_map[26:29], 31: _Prime_name[26:29],
41: _Prime_map[29:32], 41: _Prime_name[29:32],
43: _Prime_map[32:35], 43: _Prime_name[32:35],
} }
func (i Prime) String() string { func (i Prime) String() string {

2
cmd/stringer/stringer.go
View File

@ -634,7 +634,7 @@ func (g *Generator) buildMap(runs [][]Value, typeName string) {
n := 0 n := 0
for _, values := range runs { for _, values := range runs {
for _, value := range values { for _, value := range values {
g.Printf("\t%s: _%s_map[%d:%d],\n", &value, typeName, n, n+len(value.name)) g.Printf("\t%s: _%s_name[%d:%d],\n", &value, typeName, n, n+len(value.name))
n += len(value.name) n += len(value.name)
} }
} }