From 75337c43b34cbe1cd58069244b06bc246544c572 Mon Sep 17 00:00:00 2001 From: Andrew Gerrand Date: Fri, 9 Jan 2015 11:26:56 +1100 Subject: [PATCH] cmd/tipgodoc: fix some nits Change-Id: I54a98340ec2e5d54c2ca27b869c7f38b7cbfe2d7 Reviewed-on: https://go-review.googlesource.com/2536 Reviewed-by: Brad Fitzpatrick --- cmd/tipgodoc/Dockerfile | 3 ++- cmd/tipgodoc/README | 2 +- cmd/tipgodoc/tip.go | 1 - 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/cmd/tipgodoc/Dockerfile b/cmd/tipgodoc/Dockerfile index 171e43d7..23060d38 100644 --- a/cmd/tipgodoc/Dockerfile +++ b/cmd/tipgodoc/Dockerfile @@ -6,4 +6,5 @@ RUN apt-get update && apt-get install --no-install-recommends -y -q build-essent ADD . /go/src/tipgodoc RUN go install tipgodoc ENTRYPOINT ["/go/bin/tipgodoc"] -EXPOSE 8080 # what kubernetes expects +# Kubernetes expects us to listen on port 8080 +EXPOSE 8080 diff --git a/cmd/tipgodoc/README b/cmd/tipgodoc/README index 5feead7e..602e5466 100644 --- a/cmd/tipgodoc/README +++ b/cmd/tipgodoc/README @@ -1,3 +1,3 @@ To deploy as an App Engine Manged VM, use gcloud: - $ gcloud preview app deploy . + $ gcloud --project golang-org preview app deploy . diff --git a/cmd/tipgodoc/tip.go b/cmd/tipgodoc/tip.go index 61fe38e8..495c45fa 100644 --- a/cmd/tipgodoc/tip.go +++ b/cmd/tipgodoc/tip.go @@ -134,7 +134,6 @@ func initSide(side, goHash, toolsHash string) (hostport string, err error) { } if err := checkout(repoURL+"tools", toolsHash, toolsDir); err != nil { return "", err - } make := exec.Command(filepath.Join(goDir, "src/make.bash"))