From 7395529d165913577b7818a1210e11865cec1855 Mon Sep 17 00:00:00 2001 From: Alan Donovan Date: Mon, 20 Aug 2018 14:00:39 -0400 Subject: [PATCH] go/packages: disable failing test on plan9 Updates golang/go#27100 Change-Id: I41528e3635a9d7a68c84c3f089a3b4634469830d Reviewed-on: https://go-review.googlesource.com/129975 Reviewed-by: Brad Fitzpatrick --- go/packages/packages_test.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/go/packages/packages_test.go b/go/packages/packages_test.go index dab4169a..db2449d5 100644 --- a/go/packages/packages_test.go +++ b/go/packages/packages_test.go @@ -337,7 +337,10 @@ func TestLoadImportsC(t *testing.T) { if runtime.GOOS == "windows" { t.Skipf("skipping on windows; packages on windows do not satisfy conditions for test.") } - + if runtime.GOOS == "plan9" { + // See https://github.com/golang/go/issues/27100. + t.Skip(`skipping on plan9; for some reason "net [syscall.test]" is not loaded`) + } if usesOldGolist { t.Skip("not yet supported in pre-Go 1.10.4 golist fallback implementation") } @@ -365,6 +368,7 @@ func TestLoadImportsC(t *testing.T) { pkg := all[test.pattern] if pkg == nil { t.Errorf("package %q not loaded", test.pattern) + continue } if imports := strings.Join(imports(pkg), " "); !strings.Contains(imports, test.wantImport) { t.Errorf("package %q: got \n%s, \nwant to have %s", test.pattern, imports, test.wantImport)