close_issue_1
/
tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

internal/imports: disable go/packages-incompatible tests 

A recent change to the go command broke these tests. Mark them as
go/packages incompatible for now, until we have time to fix them.

Updates golang/go#33175

Change-Id: Ib4c594bd032107fb1245bfe18fc80392fbab0730
Reviewed-on: https://go-review.googlesource.com/c/tools/+/186838
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
Reviewed-by: Ian Cottrell <iancottrell@google.com>
This commit is contained in:
Rebecca Stambler 2019-07-18 18:59:26 -04:00
parent 87e92536fd
commit 72478f3938
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
internal/imports/fix_test.go
View File

@ -1306,6 +1306,7 @@ var (
"myotherpackage/toformat.go": input, "myotherpackage/toformat.go": input,
}, },
}, },
goPackagesIncompatible: true, // https://golang.org/issue/33175
}.processTest(t, "golang.org/fake", "myotherpackage/toformat.go", nil, nil, want) }.processTest(t, "golang.org/fake", "myotherpackage/toformat.go", nil, nil, want)
} }
@ -1434,6 +1435,7 @@ var _ = race.Acquire
"bar/x.go": input, "bar/x.go": input,
}, },
}, },
goPackagesIncompatible: true, // https://golang.org/issue/33175
}.processTest(t, "foo.com", "bar/x.go", nil, nil, importAdded) }.processTest(t, "foo.com", "bar/x.go", nil, nil, importAdded)
// Packages outside the same directory should not. // Packages outside the same directory should not.
@ -1646,6 +1648,7 @@ const Y = bar.X
"test/t.go": input, "test/t.go": input,
}, },
}, },
goPackagesIncompatible: true, // https://golang.org/issue/33175
}.processTest(t, "foo.com", "test/t.go", nil, nil, want) }.processTest(t, "foo.com", "test/t.go", nil, nil, want)
} }
@ -1833,6 +1836,7 @@ const Y = foo.X
"x/x.go": input, "x/x.go": input,
}, },
}, },
goPackagesIncompatible: true, // https://golang.org/issue/33175
}.processTest(t, "foo.com", "x/x.go", nil, nil, want) }.processTest(t, "foo.com", "x/x.go", nil, nil, want)
} }
@ -2139,6 +2143,7 @@ var _ = pkg.DoIt
"pkg/x_test.go": input, "pkg/x_test.go": input,
}, },
}, },
goPackagesIncompatible: true, // https://golang.org/issue/33175
}.processTest(t, "foo.com", "pkg/x_test.go", nil, nil, want) }.processTest(t, "foo.com", "pkg/x_test.go", nil, nil, want)
} }