go.tools/dashboard: Make sure links to commits and logs are dashboard specific.

R=adg
CC=golang-dev
https://golang.org/cl/14297043
This commit is contained in:
Chris Manghane 2013-10-02 15:55:44 -07:00
parent 401293d22c
commit 691b055ea6
3 changed files with 10 additions and 7 deletions

View File

@ -11,7 +11,7 @@ api_version: go1
handlers:
- url: /static
static_dir: static
- url: /log/.+
- url: /(|gccgo/)log/.+
script: _go_app
- url: /(|gccgo/)(|commit|packages|result|tag|todo)
script: _go_app

View File

@ -306,8 +306,11 @@ func shortUser(user string) string {
var repoRe = regexp.MustCompile(`^code\.google\.com/p/([a-z0-9\-]+)(\.[a-z0-9\-]+)?$`)
// repoURL returns the URL of a change at a Google Code repository or subrepo.
func repoURL(hash, packagePath string) (string, error) {
func repoURL(dashboard, hash, packagePath string) (string, error) {
if packagePath == "" {
if dashboard == "Gccgo" {
return "https://code.google.com/p/gofrontend/source/detail?r=" + hash, nil
}
return "https://code.google.com/p/go/source/detail?r=" + hash, nil
}
m := repoRe.FindStringSubmatch(packagePath)

View File

@ -107,14 +107,14 @@
</tr>
{{range $c := $.Commits}}
<tr class="commit">
<td class="hash"><a href="{{repoURL .Hash ""}}">{{shortHash .Hash}}</a></td>
<td class="hash"><a href="{{repoURL $.Dashboard.Name .Hash ""}}">{{shortHash .Hash}}</a></td>
{{range $.Builders}}
<td class="result">
{{with $c.Result . ""}}
{{if .OK}}
<span class="ok">ok</span>
{{else}}
<a href="/log/{{.LogHash}}" class="fail">fail</a>
<a href="{{$.Dashboard.RelPath}}log/{{.LogHash}}" class="fail">fail</a>
{{end}}
{{else}}
&nbsp;
@ -145,7 +145,7 @@
{{if .Packages}}
<h2>
Sub-repositories at tip
<small>(<a href="{{repoURL .Tag.Hash ""}}">{{shortHash .Tag.Hash}}</a>)</small>
<small>(<a href="{{repoURL $.Dashboard.Name .Tag.Hash ""}}">{{shortHash .Tag.Hash}}</a>)</small>
</h2>
<table class="build">
@ -185,7 +185,7 @@
<td><a title="{{.Package.Path}}">{{.Package.Name}}</a></td>
<td class="hash">
{{$h := $pkg.Commit.Hash}}
<a href="{{repoURL $h $pkg.Commit.PackagePath}}">{{shortHash $h}}</a>
<a href="{{repoURL $.Dashboard.Name $h $pkg.Commit.PackagePath}}">{{shortHash $h}}</a>
</td>
{{range $.Builders}}
<td class="result">
@ -193,7 +193,7 @@
{{if .OK}}
<span class="ok">ok</span>
{{else}}
<a href="/log/{{.LogHash}}" class="fail">fail</a>
<a href="{{$.Dashboard.RelPath}}log/{{.LogHash}}" class="fail">fail</a>
{{end}}
{{else}}
&nbsp;